[vcpkg] Fix build for mingw #15504
Merged
[vcpkg] Fix build for mingw #15504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
none of the major three implementations have string::const_iterator = char const*
JackBoosY
added
the
category:vcpkg-bug
JackBoosY
approved these changes
Jan 8, 2021
BillyONeal
approved these changes
Jan 8, 2021
strega-nil
added a commit
to strega-nil/vcpkg
that referenced
this pull request
May 5, 2021
* fix build * stop the templateness none of the major three implementations have string::const_iterator = char const*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
u8pathto always allowstring::const_iterator, even on non-MSVC. We had the split before because I thought thatstd::is_same_v<char const*, string::const_iterator>was an implementation choice made by some standard libraries, but that isn't accurate.Fixes #10349