Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[type-safe] New port. #15468

Merged
merged 3 commits into from
Jan 8, 2021
Merged

[type-safe] New port. #15468

merged 3 commits into from
Jan 8, 2021

Conversation

blaz-kranjc
Copy link
Contributor

[debug-assert] Added as it is a dependency.

  • What does your PR fix? Fixes [type_safe] #10804 (currently closed without resolution)

  • Which triplets are supported/not supported? All triplets should be supported.

  • Have you updated the CI baseline? No, the build should pass everywhere so the default should do.

  • Does your PR follow the maintainer guide? Yes, except adding an additional port to the same pull request.

[debug-assert] Added as it is a dependency.
@ghost
Copy link

ghost commented Jan 5, 2021

CLA assistant check
All CLA requirements met.

@PhoebeHui PhoebeHui added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Jan 6, 2021
@blaz-kranjc blaz-kranjc requested a review from PhoebeHui January 6, 2021 10:12
@JackBoosY JackBoosY added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Jan 7, 2021
@JackBoosY
Copy link
Contributor

LGTM.
Phoebe is OOF and I took over this PR.

@vicroms vicroms merged commit 1ef1ed0 into microsoft:master Jan 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[type_safe]
4 participants