Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hidapi] Support static build #15437

Merged
merged 2 commits into from
Jan 5, 2021
Merged

Conversation

PhoebeHui
Copy link
Contributor

Fixes #15422

hidapi doesn't configure with static build in poject files, it generates dynamic library when build with static, and simiply remove the bin directory in vcpkg, which is wrong.

Fix the issue and supports the static build.

@PhoebeHui PhoebeHui added category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Jan 4, 2021
@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Jan 5, 2021
@vicroms vicroms merged commit 1aba77a into microsoft:master Jan 5, 2021
@PhoebeHui PhoebeHui deleted the dev/Phoebe/hidapi branch February 7, 2021 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hidapi build failure: static build ships an import library
3 participants