Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tmx] Update tmx port to 1.1.0 #15421

Merged
merged 3 commits into from
Jan 8, 2021
Merged

Conversation

jarruda
Copy link
Contributor

@jarruda jarruda commented Jan 2, 2021

Describe the pull request
Updates TMX port to the latest release, 1.1.0 from 1.0.0.

  • What does your PR fix? Fixes #
    I was receiving linker errors against version 1.0.0 that this fixed. No issue tracking it.

  • Which triplets are supported/not supported? Have you updated the CI baseline?
    Only tested x64-linux. CI baseline was not mentioned in the maintainter guide so I don't know what that is.

  • Does your PR follow the maintainer guide?
    I believe so.

@jarruda jarruda marked this pull request as ready for review January 2, 2021 14:59
@NancyLi1013 NancyLi1013 added the category:port-update The issue is with a library, which is requesting update new revision label Jan 4, 2021
Copy link
Contributor

@NancyLi1013 NancyLi1013 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please update the version in CONTROL file?

Also update the copyright as the follows:

configure_file(${SOURCE_PATH}/COPYING ${CURRENT_PACKAGES_DIR}/share/${PORT}/copyright COPYONLY)

@jarruda jarruda requested a review from NancyLi1013 January 6, 2021 02:27
@NancyLi1013 NancyLi1013 added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Jan 6, 2021
@NancyLi1013
Copy link
Contributor

LGTM now, thanks for your PR @jarruda.

@vicroms vicroms merged commit 45e0eb4 into microsoft:master Jan 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants