Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mdnsresponder] Change compile flag /Zi to /Z7 #15340

Merged
merged 1 commit into from
Dec 30, 2020
Merged

[mdnsresponder] Change compile flag /Zi to /Z7 #15340

merged 1 commit into from
Dec 30, 2020

Conversation

JackBoosY
Copy link
Contributor

In order to embed debugging information in the static library, set /Z7 instead of /Zi to sync with vcpkg_configure_cmake.

Fixes #13955.

@JackBoosY JackBoosY added category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:internal This PR or Issue was filed by the vcpkg team. labels Dec 28, 2020
@JackBoosY JackBoosY requested a review from PhoebeHui December 29, 2020 01:29
@PhoebeHui PhoebeHui added the info:reviewed Pull Request changes follow basic guidelines label Dec 29, 2020
@vicroms vicroms merged commit d5b47fc into microsoft:master Dec 30, 2020
@vicroms
Copy link
Member

vicroms commented Dec 30, 2020

Thanks for the PR!

@JackBoosY JackBoosY deleted the dev/jack/13955 branch December 30, 2020 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillyONeal BillyONeal BillyONeal approved these changes

@PhoebeHui PhoebeHui PhoebeHui approved these changes

Assignees

@PhoebeHui PhoebeHui

Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[mdnsresponder] Add debug info to static libraries
4 participants
@JackBoosY @vicroms @BillyONeal @PhoebeHui