Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix licensingfile of kf5archive #15314

Merged
merged 3 commits into from
Jan 5, 2021
Merged

Conversation

Hendiadyoin1
Copy link
Contributor

Describe the pull request

Fix issue related to the missing/renaming of a file in newer versions of kf5archive as described in #15304

  • ports: all

@BillyONeal
Copy link
Member

I'm not sure I understand; if the ref didn't change, and therefore the content we are starting with didn't change, how did the file disappear in the original issue report? Was that build actually using --head or something like that instead?

@Hendiadyoin1
Copy link
Contributor Author

Before it was using a file/directory named COPYING.LIB and now it's using a directory called LICENSING.

I build the library without the --head flag.

@Hoikas
Copy link
Contributor

Hoikas commented Dec 27, 2020

It looks like COPYING.LIB does not exist in the v5.74.0 tag at all. Is it legal for copyright to be a directory in vcpkg?

@JackBoosY JackBoosY self-assigned this Dec 28, 2020
@JackBoosY JackBoosY added requires:discussion category:port-bug The issue is with a library, which is something the port should already support labels Dec 28, 2020
@JackBoosY
Copy link
Contributor

@BillyONeal The issue DOES exist, don't know why.

Copy link
Contributor

@JackBoosY JackBoosY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please bump the port version. See documentation.

@Hendiadyoin1
Copy link
Contributor Author

Please bump the port version. See documentation.

If you mean just the port version, there was none before,
if you meen the library version on the otherhand, i'd have to do the same thing for ecm and the other kf5 libraries as well

@Hendiadyoin1
Copy link
Contributor Author

Another pull request propabbly fixing these issues is #13467, where as the version they are updtaing to is already not uptodate, though better than the current one (0.10 versions)

@Hoikas
Copy link
Contributor

Hoikas commented Jan 2, 2021

If you mean just the port version, there was none before,

Because you have updated the port, you need to add Port-Version: 1 to the CONTROL file.

@ghost
Copy link

ghost commented Jan 2, 2021

CLA assistant check
All CLA requirements met.

@Hendiadyoin1
Copy link
Contributor Author

Port-version got bumped to 1, although an update to newer version may be recommended

@Hendiadyoin1 Hendiadyoin1 requested a review from JackBoosY January 3, 2021 18:49
@JackBoosY JackBoosY added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Jan 4, 2021
@vicroms vicroms merged commit 35e978a into microsoft:master Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants