Add testing with VS2015 and VS2017 compilers. #15257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BillyONeal
added
info:internal
strega-nil
reviewed
Dec 23, 2020
strega-nil
reviewed
Dec 23, 2020
ras0219
approved these changes
Dec 29, 2020
| @@ -39,6 +39,10 @@ jobs: | |||
| cmake.exe -G Ninja -DCMAKE_BUILD_TYPE=Debug -DBUILD_TESTING=ON -DVCPKG_DEVELOPMENT_WARNINGS=ON -DVCPKG_WARNINGS_AS_ERRORS=ON -DVCPKG_BUILD_FUZZING=ON -B build.x86.debug -S toolsrc | |||
| ninja.exe -C build.x86.debug | |||
| build.x86.debug\vcpkg-test.exe | |||
| cmake -G "Visual Studio 16 2019" -A Win32 -T v140 -DBUILD_TESTING=OFF -DVCPKG_DEVELOPMENT_WARNINGS=OFF -DVCPKG_WARNINGS_AS_ERRORS=ON -DVCPKG_BUILD_FUZZING=OFF -B build.x86.vs2015 -S toolsrc | |||
There was a problem hiding this comment.
Do we possibly want to build without warnings as errors in older VS versions, since we will be building with them as errors in the newer version?
There was a problem hiding this comment.
Nicole asked for warnings as errors everywhere and it didn't bother me enough to mess with it. I'd prefer to get this validation in and that switch can be changed later when the whole team is in the office to argue about it.
There was a problem hiding this comment.
There may be warnings in older compilers that don't exist in later versions; I want to make sure we catch those warnings.
Jimmy-Hu
added a commit
to Jimmy-Hu/vcpkg
that referenced
this pull request
Dec 29, 2020
Add testing with VS2015 and VS2017 compilers. (microsoft#15257)
ryukw7
pushed a commit
to ryukw7/vcpkg
that referenced
this pull request
Dec 29, 2020
* Add testing with VS2015 and VS2017 compilers. * Apply Nicole CRs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.