[protobuf] Fix the default proto file path #15246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JackBoosY
added
category:port-bug
|
Hi @sighingnow, can you test this PR? Thanks. |
|
Thanks for fixing that so quickly, will test it ASAP. |
NancyLi1013
approved these changes
Dec 22, 2020
|
@sighingnow Does this work? |
Sorry for the delay, I will test it tonight after I back to home. |
Confirm fixed. @JackBoosY Thanks for your work! Now this PR should be mergeable. |
|
Could we get this one merged? Then we could submit our package port to vcpkg. |
|
Ping @BillyONeal for merge this PR. |
BillyONeal
approved these changes
Dec 28, 2020
|
Thanks for your help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the vcpkg policy is that all tools should be installed in the tools directory, this is inconsistent with the default installation path of protobuf itself(bin), which leads to the problem of protobuf automatically finding the include path.
Fix this.
See source code:
https://github.com/protocolbuffers/protobuf/blob/64dd751868d633421563e53e68da831a0a02c923/src/google/protobuf/compiler/command_line_interface.cc#L256-L272
fixes #15217.
Note: already tested the executable usage manually.