Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[x-plane] Update to 3.0.3 #15244

Merged
merged 8 commits into from
Dec 23, 2020
Merged

[x-plane] Update to 3.0.3 #15244

merged 8 commits into from
Dec 23, 2020

Conversation

siavee
Copy link
Contributor

@siavee siavee commented Dec 22, 2020 •
edited
Loading

Describe the pull request

  • What does your PR fix?

    Updated x-plane package to latest (3.0.3) & changed macOS lib deployment to include .framework directories as it is in the original package.

  • Which triplets are supported/not supported? Have you updated the CI baseline?

    Package is header & precompiled lib only

  • Does your PR follow the maintainer guide?

    Yes

@ghost
Copy link

ghost commented Dec 22, 2020 •
edited by ghost
Loading

CLA assistant check
All CLA requirements met.

@siavee siavee marked this pull request as draft December 22, 2020 03:19
@siavee siavee marked this pull request as ready for review December 22, 2020 03:32
@siavee siavee changed the title Greatshot [x-plane] Update to 3.0.3 Dec 22, 2020
@NancyLi1013 NancyLi1013 self-assigned this Dec 22, 2020
NancyLi1013
NancyLi1013 suggested changes Dec 22, 2020
View reviewed changes
@NancyLi1013
Copy link
Contributor

NancyLi1013 commented Dec 22, 2020 •
edited
Loading

Hi @siavee

Thanks for your PR.

Could you please help check the build status on arm, uwp and linux for the new version?

If they have passed, please remove these codes from ci.baseline.txt.

x-plane:arm64-windows=fail
x-plane:arm-uwp=fail
x-plane:x64-linux=fail
x-plane:x86-windows=fail

x-plane:x86-windows=fail can be removed now since you have added supports: !x86 in vcpkg.json.

@NancyLi1013 NancyLi1013 added category:port-update The issue is with a library, which is requesting update new revision requires:author-response labels Dec 22, 2020
@siavee
Copy link
Contributor Author

siavee commented Dec 22, 2020

Hi @NancyLi1013 thanks for the review, the SDK is x64 only so arm is definitely unsupported. I've tested x64-linux to be working find. I'll update the requested files in a bit.

NancyLi1013
NancyLi1013 suggested changes Dec 22, 2020
View reviewed changes
@NancyLi1013
Copy link
Contributor

Please help update the test result on Linux, thanks.

@siavee
Copy link
Contributor Author

siavee commented Dec 22, 2020

Roger, in a bit

@siavee
Copy link
Contributor Author

siavee commented Dec 22, 2020

Working fine in Linux.

@NancyLi1013 NancyLi1013 added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Dec 23, 2020
@NancyLi1013
Copy link
Contributor

LGTM now, thanks for your PR @siavee.

@siavee
Copy link
Contributor Author

siavee commented Dec 23, 2020

Thanks for the review too @NancyLi1013 :)

@BillyONeal BillyONeal merged commit d1df265 into microsoft:master Dec 23, 2020
@BillyONeal
Copy link
Member

Thank you!

@siavee
Copy link
Contributor Author

siavee commented Dec 23, 2020

And thank you to you too!

ryukw7 pushed a commit to ryukw7/vcpkg that referenced this pull request Dec 24, 2020
@siavee
[x-plane] Update to 3.0.3 (microsoft#15244)
9c5c5a0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NancyLi1013 NancyLi1013 NancyLi1013 approved these changes

Assignees

@NancyLi1013 NancyLi1013

Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@siavee @NancyLi1013 @BillyONeal