-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[gloo] New Port #15219
[gloo] New Port #15219
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for your contribution!
Could you add the homepage in vcpkg.json file?
Co-authored-by: Phoebe <[email protected]>
One odd thing I can't make work for this port - the contents of
which seems to be some sort of default. Since the library doesn't provide any imported targets or a config module, I wrote a CMake wrapper which is also in this commit, but I wanted to make the proper usage show up accordingly. @PhoebeHui any idea what I'm doing wrong? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jacobkahn, I noticed gloo provided cmake config and targets file, so you don't need to add the FindGloo.cmake, wrapper and usage file, could you remove them?
BTW, You may need use vcpkg_fixup_cmake_targets to fix up the targets file.
See https://github.com/facebookincubator/gloo/tree/master/cmake
https://github.com/facebookincubator/gloo/blob/master/CMakeLists.txt#L129
@PhoebeHui — I didn't even notice that, good catch 👍 Removed the usage, updated, the port, and added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for your updates!
Co-authored-by: Billy O'Neal <[email protected]>
Thanks for your help! |
Add a port for gloo.
cc @xw285cornell, @mrshenli, @pbelevich, @osalpekar
cc @syhw, @padentomasello, @tlikhomanenko, @vineelpratap, @xuqiantong, @avidov
x64-linux
, which I've tested. I'm can't tell if there's windows support at this time -- the docs suggest no, but a project maintainer might be able to help me out here. I don't have the means to test it.Yes