Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[zziplib] Uses upstream CMakeLists.txt #15215

Merged
merged 8 commits into from
Dec 24, 2020
Merged

[zziplib] Uses upstream CMakeLists.txt #15215

merged 8 commits into from
Dec 24, 2020

Conversation

longnguyen2004
Copy link
Contributor

Describe the pull request

@longnguyen2004
Copy link
Contributor Author

longnguyen2004 commented Dec 19, 2020 •
edited
Loading

Can someone get osx, linux and uwp build logs for me?

@longnguyen2004 longnguyen2004 mentioned this pull request Dec 21, 2020
Merged
@NancyLi1013
Copy link
Contributor

Please see the details here
https://dev.azure.com/vcpkg/public/_build/results?buildId=46773&view=artifacts&pathAsName=false&type=publishedArtifacts

Since there is something wrong on osx, we cannot get logs on osx now.

The failures on Linux:

CMake Error at zzip/CMakeLists.txt:315 (get_target_property):
  get_target_property() called with non-existent target "libzzipfseeko".


CMake Error at zzip/CMakeLists.txt:316 (get_target_property):
  get_target_property() called with non-existent target "libzzipfseeko".


CMake Error at zzip/CMakeLists.txt:317 (get_target_property):
  get_target_property() called with non-existent target "libzzipfseeko".


CMake Error at zzip/CMakeLists.txt:330 (get_target_property):
  get_target_property() called with non-existent target "libzzipmmapped".


CMake Error at zzip/CMakeLists.txt:331 (get_target_property):
  get_target_property() called with non-existent target "libzzipmmapped".


CMake Error at zzip/CMakeLists.txt:332 (get_target_property):
  get_target_property() called with non-existent target "libzzipmmapped".

The failures on uwp:

4>D:\buildtrees\zziplib\src\97c6f3df29-1240d2902f.clean\zzip\err.c(70,20): error C4996: 'strerror': This function or variable may be unsafe. Consider using strerror_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\buildtrees\zziplib\x64-uwp-dbg\zzip\libzzip.vcxproj]
     4>D:\buildtrees\zziplib\src\97c6f3df29-1240d2902f.clean\zzip/__dirent.h(174,12): error C4996: 'strcpy': This function or variable may be unsafe. Consider using strcpy_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. (compiling source file D:\buildtrees\zziplib\src\97c6f3df29-1240d2902f.clean\zzip\dir.c) [D:\buildtrees\zziplib\x64-uwp-dbg\zzip\libzzip.vcxproj]
     4>D:\buildtrees\zziplib\src\97c6f3df29-1240d2902f.clean\zzip\err.c(75,12): error C4996: 'strerror': This function or variable may be unsafe. Consider using strerror_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\buildtrees\zziplib\x64-uwp-dbg\zzip\libzzip.vcxproj]
     4>D:\buildtrees\zziplib\src\97c6f3df29-1240d2902f.clean\zzip/__dirent.h(180,9): error C4996: 'strcat': This function or variable may be unsafe. Consider using strcat_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. (compiling source file D:\buildtrees\zziplib\src\97c6f3df29-1240d2902f.clean\zzip\dir.c) [D:\buildtrees\zziplib\x64-uwp-dbg\zzip\libzzip.vcxproj]
     4>D:\buildtrees\zziplib\src\97c6f3df29-1240d2902f.clean\zzip\err.c(87,16): error C4996: 'strerror': This function or variable may be unsafe. Consider using strerror_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\buildtrees\zziplib\x64-uwp-dbg\zzip\libzzip.vcxproj]
     4>D:\buildtrees\zziplib\src\97c6f3df29-1240d2902f.clean\zzip/__dirent.h(184,12): error C4996: 'strcat': This function or variable may be unsafe. Consider using strcat_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. (compiling source file D:\buildtrees\zziplib\src\97c6f3df29-1240d2902f.clean\zzip\dir.c) [D:\buildtrees\zziplib\x64-uwp-dbg\zzip\libzzip.vcxproj]
     4>D:\buildtrees\zziplib\src\97c6f3df29-1240d2902f.clean\zzip\plugin.c(45,6): error C4996: 'open': The POSIX name for this item is deprecated. Instead, use the ISO C and C++ conformant name: _open. See online help for details. [D:\buildtrees\zziplib\x64-uwp-dbg\zzip\libzzip.vcxproj]

@NancyLi1013 NancyLi1013 added category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist requires:author-response labels Dec 21, 2020
@longnguyen2004 longnguyen2004 mentioned this pull request Dec 22, 2020
Closed
@vadi2
Copy link
Contributor

vadi2 commented Dec 22, 2020

Can you merge latest development? It fails on building the dependency zlib before it can get to zziplib.

@longnguyen2004
Copy link
Contributor Author

longnguyen2004 commented Dec 22, 2020 •
edited
Loading

@vadi2 Can you give me the build log?
Oh wait, you mean merge master into this? Sure

@vadi2
Copy link
Contributor

vadi2 commented Dec 22, 2020

Yeah.

vadi2
vadi2 approved these changes Dec 22, 2020
View reviewed changes
Copy link
Contributor

@vadi2 vadi2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds OK

@NancyLi1013 NancyLi1013 added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Dec 23, 2020
@BillyONeal BillyONeal merged commit 6654632 into microsoft:master Dec 24, 2020
@BillyONeal
Copy link
Member

Thanks for getting us to use upstream things! :D

@longnguyen2004 longnguyen2004 deleted the zziplib-mingw branch December 24, 2020 01:29
ryukw7 pushed a commit to ryukw7/vcpkg that referenced this pull request Dec 24, 2020
@longnguyen2004
[zziplib] Uses upstream CMakeLists.txt (microsoft#15215)
7047151
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vadi2 vadi2 vadi2 approved these changes

@NancyLi1013 NancyLi1013 NancyLi1013 approved these changes

Assignees

@NancyLi1013 NancyLi1013

Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[zziplib] x64-mingw-dynamic build failure
4 participants
@longnguyen2004 @NancyLi1013 @vadi2 @BillyONeal