-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[qt5-base] mysql plugin added #15170
Conversation
Update to 2020-12-16
Hi. Because I can try to fix for all configuration that I have, I can't test every of them (I don't have linux machines or osx for example) so I cannot perform local tests and I cannot check what's wrong with them. |
|
@JackBoosY ok thanks a lot |
cc @Neumann-A for review this PR. |
@Neumann-A said this should be added as a qt5-base feature. |
Ok I'll add it as feature ASAP. |
The MySQL plugin for QT now is a module of qt5-base
I've set the mysql plugin as qt5-base feature. |
LGTM. |
I think it should be there, because there's already sqlite and postgresql. Since they are all plugin, or we put them all together at once or none of them in my opinion. There's no reason to include postgresql plugin by default and not mysql, or vice versa. Since postgresql plugin is already installed by default with qt5 I've followed the same logic (it was the reason why I did't added it with a separate feature at start). |
No...no... the
I will open a PR to remove the default feature. |
The pull request creates the qsqlmysql database plugin for qt5-base.
It adds a dependency from libmysql in order to build it before the plugin since it's requested.