-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[magnum,magnum-plugins] Add vulkan and shaderconverter features #15163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b15b1c9
to
ec66a17
Compare
mosra
approved these changes
Dec 16, 2020
JackBoosY
suggested changes
Dec 17, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please bump the port version. See documentation.
ec66a17
to
a9c21f2
Compare
@JackBoosY Sorry about that! Fixed. |
207c35c
to
1da587a
Compare
@JackBoosY Ready to be merged! :) |
Did you test all features? |
JackBoosY
suggested changes
Dec 20, 2020
Signed-off-by: Squareys <[email protected]>
…rsion Signed-off-by: Squareys <[email protected]>
1da587a
to
8b14116
Compare
JackBoosY
approved these changes
Jan 26, 2021
Need test all features. |
Test all features succesfully on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
category:port-feature
The issue is with a library, which is requesting new capabilities that didn’t exist
info:reviewed
Pull Request changes follow basic guidelines
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all!
This PR adds a few new features available in magnum HEAD.
Best,
Jonathan
(As per usual, @mosra will quickly review and approve from his side.)