Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[magnum,magnum-plugins] Add vulkan and shaderconverter features #15163

Merged
merged 4 commits into from
Jan 26, 2021

Conversation

Squareys
Copy link
Contributor

Hi all!

This PR adds a few new features available in magnum HEAD.

Best,
Jonathan

(As per usual, @mosra will quickly review and approve from his side.)

@JackBoosY JackBoosY added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Dec 17, 2020
Copy link
Contributor

@JackBoosY JackBoosY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please bump the port version. See documentation.

@Squareys
Copy link
Contributor Author

@JackBoosY Sorry about that! Fixed.

@Squareys Squareys force-pushed the magnum-add-vk branch 6 times, most recently from 207c35c to 1da587a Compare December 18, 2020 13:14
@Squareys
Copy link
Contributor Author

@JackBoosY Ready to be merged! :)

@JackBoosY
Copy link
Contributor

Did you test all features?

@JackBoosY
Copy link
Contributor

Need test all features.

@JackBoosY
Copy link
Contributor

Test all features succesfully on x86-windows and x64-windows-static.

@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Jan 26, 2021
@dan-shaw dan-shaw merged commit 7955885 into microsoft:master Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants