Properly index package actions in log #15076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ras0219
approved these changes
Dec 13, 2020
JackBoosY
added
the
category:vcpkg-bug
JackBoosY
approved these changes
Dec 14, 2020
|
Probably fixes #13130 |
|
Thanks for your help! |
ryukw7
pushed a commit
to ryukw7/vcpkg
that referenced
this pull request
Dec 15, 2020
strega-nil
pushed a commit
to strega-nil/vcpkg
that referenced
this pull request
May 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
When running
vcpkg installwith some packages already installed, invalid message of typeStarting package 3/2: opencl:x64-linuxmay occur. It happens becauseresultsvector might contain already installed actions, while they are not counted in the total number of actions.Tested myself on
x64-linux.Yes.