Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mp3lame] Fix lib suffix on Unix #15058

Merged
merged 1 commit into from
Dec 12, 2020

Conversation

NancyLi1013
Copy link
Contributor

Describe the pull request

Currently, _mp3lame_rel_lib in ../share/mp3lame/mp3lame-config.cmake is like this:

set(_mp3lame_rel_lib "${_mp3lame_root}/lib/libmp3lame..a")
set(_mp3lame_dbg_lib "${_mp3lame_root}/debug/lib/libmp3lame..a")

VCPKG_TARGET_STATIC_LIBRARY_SUFFIX has included ".", it's unnecessary to add it again.

So remove additional "." , only using ${VCPKG_TARGET_STATIC_LIBRARY_SUFFIX} to fix this issue.

Note: No feature needs to test.

@NancyLi1013 NancyLi1013 added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Dec 11, 2020
@PhoebeHui PhoebeHui added the info:reviewed Pull Request changes follow basic guidelines label Dec 11, 2020
@BillyONeal BillyONeal merged commit 929c7d9 into microsoft:master Dec 12, 2020
@BillyONeal
Copy link
Member

Excellent!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[libx264] build failure on linux
3 participants