Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[opencascade] Fix OpenCASCADE_INSTALL_PREFIX path in config #15056

Merged
merged 1 commit into from
Dec 12, 2020
Merged

[opencascade] Fix OpenCASCADE_INSTALL_PREFIX path in config #15056

merged 1 commit into from
Dec 12, 2020

Conversation

NancyLi1013
Copy link
Contributor

Describe the pull request

Currently, OpenCASCADE_INSTALL_PREFIX path is like this:

OpenCASCADE_INSTALL_PREFIX=D:/vcpkg/installed/x64-windows/share

This causes OpenCASCADE_INCLUDE_DIR and OpenCASCADE_LIBRARY_DIR are wrong.

OpenCASCADE_INCLUDE_DIR =D:/vcpkg/installed/x64-windows/share/include/opencascade

OpenCASCADE_LIBRARY_DIR=D:/vcpkg/installed/x64-windows/share/lib

So need to fix OpenCASCADE_INSTALL_PREFIX path.

Note: All features are not needed to test.

@NancyLi1013 NancyLi1013 added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Dec 11, 2020
@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Dec 11, 2020
@BillyONeal BillyONeal merged commit 3b935db into microsoft:master Dec 12, 2020
@BillyONeal
Copy link
Member

Thank you!

@socuwn
Copy link
Contributor

socuwn commented Mar 8, 2021

This issue is back again after upgrade to OCC 7.5.0,
#15997

@NancyLi1013
Copy link
Contributor Author

Thanks for reporting this issue @socuwn.

I found that the patch was removed in PR #15997. I think we can add it back to PR #16513.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JackBoosY JackBoosY JackBoosY approved these changes

Assignees

@JackBoosY JackBoosY

Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[opencascade] OpenCASCADE_INCLUDE_DIR at wrong location
4 participants
@NancyLi1013 @BillyONeal @socuwn @JackBoosY