-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: [x64-windows-intel] new Triplet: #15053
Conversation
(after modifing cmakes internal rules)
/names:lowercase /assume:underscore without those flags blas is not found while with those flags lapack fails
…riplet # Conflicts: # ports/intel-mkl/CONTROL # ports/intel-mkl/portfile.cmake # ports/lapack-reference/CONTROL # ports/openblas/CONTROL # ports/openblas/portfile.cmake
Any progress? |
…riplet # Conflicts: # ports/lapack-reference/CONTROL # ports/lapack-reference/portfile.cmake # ports/lapack/CONTROL
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json
or CONTROL
must be modified.
Error: Local changes detected for blas but no changes to version or port version.
-- Version: 1#1
-- Old SHA: 0d105be9337f4a6f294a7eced2da18e8cdb99051
-- New SHA: 792155cfe55691c0c7f1fc0a8cb07fd5f86a617e
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***
Error: Local changes detected for lapack-reference but no changes to version or port version.
-- Version: 3.10.0
-- Old SHA: 14b5e3ab7315ce36951f759c6254712ed41cc0af
-- New SHA: 6fbaf51bcf60ebd79ab2bfae966d362497a923b5
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***
Error: Local changes detected for lapack but no changes to version or port version.
-- Version: 2022-02-22
-- Old SHA: 3a9c5b51e3480db058719db223df981e0e679819
-- New SHA: dbc0bc52bbfee992c890082a03638696ebaf7136
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***
You have modified or added at least one portfile where deprecated functions are used.
If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake
-> vcpkg_cmake_install
(from port vcpkg-cmake
)
vcpkg_build_cmake
-> vcpkg_cmake_build
(from port vcpkg-cmake
)
vcpkg_configure_cmake
-> vcpkg_cmake_configure
(Please remove the option PREFER_NINJA
) (from port vcpkg-cmake
)
vcpkg_fixup_cmake_targets
-> vcpkg_cmake_config_fixup
(from port vcpkg-cmake-config
)
In the ports that use the new function, you have to add the corresponding dependencies:
{
"name": "vcpkg-cmake",
"host": true
},
{
"name": "vcpkg-cmake-config",
"host": true
}
The following files are affected:
ports/blas/portfile.cmake
ports/lapack/portfile.cmake
Please temporary close this PR if you don't have spare time to finish it. |
Mainly waiting for other PRs to be merge first and if I should hijack one of the normal triplets for testing ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json
or CONTROL
must be modified.
error: checked-in files for lapack have changed but the version was not updated
version: 2022-02-22
old SHA: 3a9c5b51e3480db058719db223df981e0e679819
new SHA: dbc0bc52bbfee992c890082a03638696ebaf7136
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
error: checked-in files for lapack-reference have changed but the version was not updated
version: 3.10.1
old SHA: 44ad48321efe7014cd1dc7ab7b46516309e6c395
new SHA: 01f65ff778f142ac2fdf838d67f82ac93b118c64
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
error: checked-in files for blas have changed but the version was not updated
version: 1#1
old SHA: 0d105be9337f4a6f294a7eced2da18e8cdb99051
new SHA: 792155cfe55691c0c7f1fc0a8cb07fd5f86a617e
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
You have modified or added at least one portfile where deprecated functions are used.
If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake
-> vcpkg_cmake_install
(from port vcpkg-cmake
)
vcpkg_build_cmake
-> vcpkg_cmake_build
(from port vcpkg-cmake
)
vcpkg_configure_cmake
-> vcpkg_cmake_configure
(Please remove the option PREFER_NINJA
) (from port vcpkg-cmake
)
vcpkg_fixup_cmake_targets
-> vcpkg_cmake_config_fixup
(from port vcpkg-cmake-config
)
In the ports that use the new function, you have to add the corresponding dependencies:
{
"name": "vcpkg-cmake",
"host": true
},
{
"name": "vcpkg-cmake-config",
"host": true
}
The following files are affected:
ports/blas/portfile.cmake
ports/lapack/portfile.cmake
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json
or CONTROL
must be modified.
error: checked-in files for lapack have changed but the version was not updated
version: 2022-02-22
old SHA: 3a9c5b51e3480db058719db223df981e0e679819
new SHA: dbc0bc52bbfee992c890082a03638696ebaf7136
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
error: checked-in files for lapack-reference have changed but the version was not updated
version: 3.10.1
old SHA: 44ad48321efe7014cd1dc7ab7b46516309e6c395
new SHA: 01f65ff778f142ac2fdf838d67f82ac93b118c64
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
error: checked-in files for blas have changed but the version was not updated
version: 1#1
old SHA: 0d105be9337f4a6f294a7eced2da18e8cdb99051
new SHA: 792155cfe55691c0c7f1fc0a8cb07fd5f86a617e
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
You have modified or added at least one portfile where deprecated functions are used.
If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake
-> vcpkg_cmake_install
(from port vcpkg-cmake
)
vcpkg_build_cmake
-> vcpkg_cmake_build
(from port vcpkg-cmake
)
vcpkg_configure_cmake
-> vcpkg_cmake_configure
(Please remove the option PREFER_NINJA
) (from port vcpkg-cmake
)
vcpkg_fixup_cmake_targets
-> vcpkg_cmake_config_fixup
(from port vcpkg-cmake-config
)
In the ports that use the new function, you have to add the corresponding dependencies:
{
"name": "vcpkg-cmake",
"host": true
},
{
"name": "vcpkg-cmake-config",
"host": true
}
The following files are affected:
ports/blas/portfile.cmake
ports/lapack/portfile.cmake
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json
or CONTROL
must be modified.
error: checked-in files for lapack-reference have changed but the version was not updated
version: 3.10.1
old SHA: 44ad48321efe7014cd1dc7ab7b46516309e6c395
new SHA: 01f65ff778f142ac2fdf838d67f82ac93b118c64
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
error: checked-in files for lapack have changed but the version was not updated
version: 2022-02-22
old SHA: 3a9c5b51e3480db058719db223df981e0e679819
new SHA: dbc0bc52bbfee992c890082a03638696ebaf7136
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
error: checked-in files for blas have changed but the version was not updated
version: 1#1
old SHA: 0d105be9337f4a6f294a7eced2da18e8cdb99051
new SHA: 792155cfe55691c0c7f1fc0a8cb07fd5f86a617e
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
You have modified or added at least one portfile where deprecated functions are used.
If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake
-> vcpkg_cmake_install
(from port vcpkg-cmake
)
vcpkg_build_cmake
-> vcpkg_cmake_build
(from port vcpkg-cmake
)
vcpkg_configure_cmake
-> vcpkg_cmake_configure
(Please remove the option PREFER_NINJA
) (from port vcpkg-cmake
)
vcpkg_fixup_cmake_targets
-> vcpkg_cmake_config_fixup
(from port vcpkg-cmake-config
)
In the ports that use the new function, you have to add the corresponding dependencies:
{
"name": "vcpkg-cmake",
"host": true
},
{
"name": "vcpkg-cmake-config",
"host": true
}
The following files are affected:
ports/blas/portfile.cmake
ports/lapack/portfile.cmake
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json
or CONTROL
must be modified.
error: checked-in files for lapack-reference have changed but the version was not updated
version: 3.10.1
old SHA: 44ad48321efe7014cd1dc7ab7b46516309e6c395
new SHA: 01f65ff778f142ac2fdf838d67f82ac93b118c64
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
error: checked-in files for lapack have changed but the version was not updated
version: 2022-02-22
old SHA: 3a9c5b51e3480db058719db223df981e0e679819
new SHA: dbc0bc52bbfee992c890082a03638696ebaf7136
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
error: checked-in files for blas have changed but the version was not updated
version: 1#1
old SHA: 0d105be9337f4a6f294a7eced2da18e8cdb99051
new SHA: 792155cfe55691c0c7f1fc0a8cb07fd5f86a617e
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
You have modified or added at least one portfile where deprecated functions are used.
If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake
-> vcpkg_cmake_install
(from port vcpkg-cmake
)
vcpkg_build_cmake
-> vcpkg_cmake_build
(from port vcpkg-cmake
)
vcpkg_configure_cmake
-> vcpkg_cmake_configure
(Please remove the option PREFER_NINJA
) (from port vcpkg-cmake
)
vcpkg_fixup_cmake_targets
-> vcpkg_cmake_config_fixup
(from port vcpkg-cmake-config
)
In the ports that use the new function, you have to add the corresponding dependencies:
{
"name": "vcpkg-cmake",
"host": true
},
{
"name": "vcpkg-cmake-config",
"host": true
}
The following files are affected:
ports/blas/portfile.cmake
ports/lapack/portfile.cmake
Ping @Neumann-A for response. Is work still being done for this PR? |
waiting for other complicated stuff to getting merged. |
Please link other PR to here, this will make it easier for us to track this PR. |
Closing this PR as there has not been activity in over 4 months. Please feel free to reopen it, or another PR, should you wish to continue this. Note that we were recently forced to no longer install icc in the test lab, though that doesn't necessarily matter for this given that we wouldn't have made icc an official triplet anytime soon. |
Requirements:
Intel C/C++/Fortran compiler via oneAPI
manuall copy of llvm-ar and subsequent rename to llvm-ranlib.cmake platform seems to beWindows-Clang
opened:https://gitlab.kitware.com/cmake/cmake/-/issues/21588