Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CGAL] Upgrade to 5.2 #15047

Merged
merged 4 commits into from
Jan 15, 2021
Merged

[CGAL] Upgrade to 5.2 #15047

merged 4 commits into from
Jan 15, 2021

Conversation

maxGimeno
Copy link
Contributor

Upgrade CGAL to version 5.2.

@maxGimeno maxGimeno mentioned this pull request Dec 10, 2020
89 tasks
@JonLiu1993 JonLiu1993 self-assigned this Dec 11, 2020
@JonLiu1993 JonLiu1993 added the category:port-update The issue is with a library, which is requesting update new revision label Dec 11, 2020
@JonLiu1993 JonLiu1993 self-requested a review December 11, 2020 01:30
@JonLiu1993
Copy link
Member

@maxGimeno ,Thank you for your contribution, we currently recommend to update the latest stable version instead of the pre-release version, so I can't approve your pr, we will update it in time after the stable version is released!

@maxGimeno
Copy link
Contributor Author

@JonLiu1993 No problem, it was just to check that the CI tests pass, that is why I made a draft PR. I'll update the version as soon as the release is out, and "un-draft" then.

@maxGimeno maxGimeno marked this pull request as ready for review December 29, 2020 10:29
@JonLiu1993
Copy link
Member

@maxGimeno ,Have you tested the feature?

@maxGimeno
Copy link
Contributor Author

Only the installation part.

@maxGimeno
Copy link
Contributor Author

I tested an example compilation, it works

@JonLiu1993 JonLiu1993 added the info:reviewed Pull Request changes follow basic guidelines label Jan 14, 2021
@PhoebeHui
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@PhoebeHui PhoebeHui changed the title CGAL: Upgrade to 5.2 [CGAL] Upgrade to 5.2 Jan 15, 2021
@dan-shaw dan-shaw merged commit a184395 into microsoft:master Jan 15, 2021
@lrineau lrineau deleted the CGAL-5.2 branch January 18, 2021 10:12
@lrineau lrineau mentioned this pull request Jun 2, 2021
70 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants