Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[osg] build failure #15044

Merged
merged 5 commits into from
Dec 15, 2020
Merged

[osg] build failure #15044

merged 5 commits into from
Dec 15, 2020

Conversation

JonLiu1993
Copy link
Member

Describe the pull request

  • What does your PR fix? Fixes [osg] build failure #14994
    Iconv does not provide the IconvConfig.cmake file and cannot use the config mode for searching, so need to delete the CONFIG parameter in find_package (Iconv CONFIG REQUIRED)

All features have tested successfully in the following triplets:

  • x86-windows
  • x64-windows
  • x64-windows-static

@JonLiu1993 JonLiu1993 added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Dec 10, 2020
@JonLiu1993 JonLiu1993 marked this pull request as ready for review December 11, 2020 08:32
@NancyLi1013 NancyLi1013 added the info:reviewed Pull Request changes follow basic guidelines label Dec 14, 2020
@BillyONeal
Copy link
Member

Isn't Iconv::Iconv provided by the config file? I think the missing config file is the source of the problem that must be addressed, not one of the downstream consumers here.

@JonLiu1993
Copy link
Member Author

Isn't Iconv::Iconv provided by the config file? I think the missing config file is the source of the problem that must be addressed, not one of the downstream consumers here.
@BillyONeal , the cmake file provided by us before osg was written by nmake, but the cmake provided by myself was deleted in the subsequent version submitted. Now iconv does not have a configuration file that can be used

@BillyONeal
Copy link
Member

@JonLiu1993 If there's no config file where does Iconv::Iconv come from?

@BillyONeal
Copy link
Member

Robert points out that Iconv::Iconv is a cmake builtin module. Sorry for the confusion and thanks!

@BillyONeal BillyONeal merged commit c744bdf into microsoft:master Dec 15, 2020
@JonLiu1993 JonLiu1993 deleted the dev/Jon/osg branch December 23, 2020 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NancyLi1013 NancyLi1013 NancyLi1013 approved these changes

Assignees

@NancyLi1013 NancyLi1013

Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[osg] build failure
3 participants
@JonLiu1993 @BillyONeal @NancyLi1013