[qt5] Fix linux dynamic build #15005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dweckmann
force-pushed
the
qt5-fix-dynamic-build
branch
from
c6d90a7 to
3ddb154
Compare
BillyONeal
reviewed
Dec 8, 2020
BillyONeal
requested changes
Dec 8, 2020
|
cc @Neumann-A for review this PR, |
dweckmann
force-pushed
the
qt5-fix-dynamic-build
branch
3 times, most recently
from
27b69ab to
04635cc
Compare
JackBoosY
added
the
category:port-bug
Neumann-A
reviewed
Dec 9, 2020
Neumann-A
reviewed
Dec 9, 2020
dweckmann
force-pushed
the
qt5-fix-dynamic-build
branch
from
04635cc to
53daa6e
Compare
JackBoosY
approved these changes
Dec 10, 2020
Neumann-A
reviewed
Dec 10, 2020
Comment on lines
71
to
72
| set(_ld_library_path_backup_ $ENV{LD_LIBRARY_PATH}) | ||
| if(NOT "${_ld_library_path_backup_}" STREQUAL "") |
There was a problem hiding this comment.
That is incorrect. if $ENV{LD_LIBRARY_PATH} is set to "" it means .
There was a problem hiding this comment.
ok, I will use if(DEFINED ENV{<name>}). Thanks.
There was a problem hiding this comment.
You can check again. I unset the env variable if it wasn't set, otherwise I use the backup.
JackBoosY
added
requires:author-response
and removed
info:reviewed
dweckmann
force-pushed
the
qt5-fix-dynamic-build
branch
4 times, most recently
from
781e3d4 to
8bdd6f4
Compare
dweckmann
force-pushed
the
qt5-fix-dynamic-build
branch
from
8bdd6f4 to
9eee572
Compare
|
@Neumann-A Do you have any other concerns about this? |
dweckmann
force-pushed
the
qt5-fix-dynamic-build
branch
from
9eee572 to
dbf8fb7
Compare
BillyONeal
approved these changes
Dec 21, 2020
|
Thanks for your help! |
ryukw7
pushed a commit
to ryukw7/vcpkg
that referenced
this pull request
Dec 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
What does your PR fix? Fixes [qt5-base:x64-linux] build failure: [libpq] not found with dynamic linkage #14879
Which triplets are supported/not supported? x64-linux-dynamic
Basically this PR does three things:
Setting LD_LIBRARY_PATH may be somewhat dangerous, but I cannot find a better way to do that, without changing too much things. If someone have a better idea, feel free to propose !