[geogram] Fix windows dynamic build usage #14962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @FabienPean Thanks for your PR. Could you please describe what the problem is in dynamic usage? |
NancyLi1013
added
category:port-bug
|
Hi, sure ! |
NancyLi1013
reviewed
Dec 7, 2020
FabienPean
force-pushed
the
fix/geogram_dynamic
branch
from
e6de56f to
5ea2c1f
Compare
ras0219-msft
approved these changes
Feb 11, 2021
NancyLi1013
approved these changes
Feb 18, 2021
|
The regressions caused by |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the use of geogram library for triplet x64-windows. The bug has been reported upstream, but no news from maintainers so far. The PR fixes the package for current vcpkg version, and may need to be reverted when a new version of the library is released.