Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[usockets] Fix build issue with feature ssl #14935

Merged
merged 3 commits into from
Dec 5, 2020
Merged

[usockets] Fix build issue with feature ssl #14935

merged 3 commits into from
Dec 5, 2020

Conversation

PhoebeHui
Copy link
Contributor

@PhoebeHui PhoebeHui commented Dec 4, 2020 •
edited
Loading

Fixes #14933

sni* are in sni_tree.cpp, which not built in vcpkg, including this file, and it requires c++17 or later. See https://github.com/uNetworking/uSockets/blob/master/Makefile#L43

All features test pass with x64-windows and x64-windows-static

Failures:

openssl.c.obj : error LNK2019: unresolved external symbol _sni_new referenced in function _us_internal_create_ssl_socket_context
openssl.c.obj : error LNK2019: unresolved external symbol _sni_free referenced in function _us_internal_ssl_socket_context_free
openssl.c.obj : error LNK2019: unresolved external symbol _sni_add referenced in function _us_internal_ssl_socket_context_add_server_name
openssl.c.obj : error LNK2019: unresolved external symbol _sni_remove referenced in function _us_internal_ssl_socket_context_remove_server_name
openssl.c.obj : error LNK2019: unresolved external symbol _sni_find referenced in function _resolve_context
uSockets.dll : fatal error LNK1120: 5 unresolved externals

@PhoebeHui PhoebeHui added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Dec 4, 2020
@PhoebeHui PhoebeHui mentioned this pull request Dec 4, 2020
Closed
@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Dec 4, 2020
@BillyONeal BillyONeal merged commit de70813 into microsoft:master Dec 5, 2020
@BillyONeal
Copy link
Member

Thanks for your help!

@PhoebeHui PhoebeHui deleted the dev/Phoebe/usockets branch June 17, 2021 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JackBoosY JackBoosY JackBoosY approved these changes

Assignees

@JackBoosY JackBoosY

Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

uSockets[ssl] build failure
3 participants
@PhoebeHui @BillyONeal @JackBoosY