Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[arrayfire] Update port to fix cuSparse issue with CUDA 10.1 #14911

Merged
merged 1 commit into from
Dec 5, 2020

Conversation

jacobkahn
Copy link
Contributor

Patch the ArrayFire port to fix an issue with the cuSparse API in CUDA 10.1. See arrayfire/arrayfire#3057. Since this isn't going to be grafted into the v3.7 branch or the 3.7.3 tip, fix the port manually for now since the vcpkg min CUDA version is 10.1 and users might install 10.1 pre update 2 when the API is broken.

  • Which triplets are supported/not supported? Have you updated the CI baseline?

Same as before - x64*. No changes.

Yes

cc @umar456 @9prady9

@jacobkahn jacobkahn force-pushed the af_update_cusparse_patch branch from f7af8c8 to de079ec Compare December 2, 2020 17:02
@jacobkahn
Copy link
Contributor Author

Looks like this CI failure is related to building another package - vtk - on Windows. @JonLiu1993 could you possibly step in and test the port as you did before? I've tested in x64-linux.

@PhoebeHui PhoebeHui added category:port-bug The issue is with a library, which is something the port should already support requires:all-feature-testing vcpkg install port[all features supported by that port] needs to be demonstrated to function labels Dec 3, 2020
@JonLiu1993
Copy link
Member

@jacobkahn ,All features test passed with x64-windows

@PhoebeHui PhoebeHui removed the requires:all-feature-testing vcpkg install port[all features supported by that port] needs to be demonstrated to function label Dec 3, 2020
@PhoebeHui PhoebeHui added the info:reviewed Pull Request changes follow basic guidelines label Dec 4, 2020
@BillyONeal BillyONeal merged commit 2835810 into microsoft:master Dec 5, 2020
@BillyONeal
Copy link
Member

Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants