[microsoft-signalr] Fix build error on Linux #14872
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
When building on Linux, it will fail due to this error:
error: cannot use typeid with -fno-rtti
There are two reasons to fix this problem:
-fno-rtti
is only for non windows Platform.-fno-rtti
should not be added here https://github.com/aspnet/SignalR-Client-Cpp/blob/master/src/signalrclient/CMakeLists.txt#L63.So I make a patch to remove these codes.
Please see the references:
[1] https://scc.ustc.edu.cn/zlsc/tc4600/intel/2017.0.098/compiler_c/common/core/GUID-BA6071E9-2409-4118-84B5-8E1ABE0C2B72.html
[2] https://stackoverflow.com/questions/8723702/error-cannot-use-typeid-with-fno-rtti
Note: No need to test features.