Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cppgraphqlgen] Update to v3.3.0 #14842

Merged
merged 3 commits into from
Dec 7, 2020
Merged

Conversation

wravery
Copy link
Contributor

@wravery wravery commented Nov 30, 2020

Describe the pull request

  • What does your PR fix?

Updates to the v3.3.0 release of https://github.com/microsoft/cppgraphqlgen. This has been tested along with #14841 on Windows, Mac, and Linux, but it works with the prior version of PEGTL as well.

  • Which triplets are supported/not supported? Have you updated the CI baseline?

This version has the same std::filesystem auto-detection for schemagen as PEGTL in #14841. It should work on any target triplet and with all of the runners in the CI workflow.

Yes.

@JonLiu1993 JonLiu1993 self-requested a review November 30, 2020 03:00
@JonLiu1993 JonLiu1993 added the category:port-update The issue is with a library, which is requesting update new revision label Nov 30, 2020
@JonLiu1993 JonLiu1993 self-assigned this Nov 30, 2020
@wravery wravery marked this pull request as ready for review November 30, 2020 03:27
@JonLiu1993 JonLiu1993 requested review from JackBoosY and removed request for JonLiu1993 December 1, 2020 03:00
@JackBoosY
Copy link
Contributor

See my comment #14841 (comment)

@wravery wravery marked this pull request as ready for review December 6, 2020 22:06
@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Dec 7, 2020
@BillyONeal BillyONeal merged commit f093559 into microsoft:master Dec 7, 2020
@BillyONeal
Copy link
Member

Thanks for your contribution!

@wravery wravery deleted the cppgraphqlgen branch January 9, 2021 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants