Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cwalk] Add new port #14801

Merged
merged 3 commits into from
Dec 1, 2020
Merged

[cwalk] Add new port #14801

merged 3 commits into from
Dec 1, 2020

Conversation

likle
Copy link
Contributor

@likle likle commented Nov 26, 2020

Describe the pull request

  • What does your PR fix?
    "Fixes" missing cwalk port

  • Which triplets are supported/not supported? Have you updated the CI baseline?
    All should pass, no update to the CI baseline

  • Does your PR follow the maintainer guide?
    yes

@ghost
Copy link

ghost commented Nov 26, 2020

CLA assistant check
All CLA requirements met.

@likle likle changed the title added port: cwalk 1.2.5 [cwalk] Add new port Nov 26, 2020
@NancyLi1013 NancyLi1013 self-assigned this Nov 27, 2020
@NancyLi1013 NancyLi1013 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Nov 27, 2020
likle and others added 2 commits November 27, 2020 08:33
@likle likle marked this pull request as ready for review November 27, 2020 07:45
@likle likle requested a review from NancyLi1013 November 27, 2020 07:49
@NancyLi1013 NancyLi1013 added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Dec 1, 2020
@NancyLi1013
Copy link
Contributor

LGTM, thanks for your PR @likle.

@strega-nil strega-nil merged commit 5d813f3 into microsoft:master Dec 1, 2020
@strega-nil
Copy link
Contributor

Awesome, thanks @likle :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants