Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[devil] Fix pkgconfig on Windows #14793

Merged
merged 1 commit into from
Nov 30, 2020
Merged

[devil] Fix pkgconfig on Windows #14793

merged 1 commit into from
Nov 30, 2020

Conversation

JackBoosY
Copy link
Contributor

In SOURCE/DevIL/src-IL/CMakeLists.txt:

if(WIN32)
	# Linux uses libIL.so, libILU.so, and libILUT.so, but Windows uses
	#  DevIL.dll, ILU.dll, and ILUT.dll.
	set_target_properties(IL PROPERTIES OUTPUT_NAME "DevIL")
endif(WIN32)

This will caused the wrong name in its pkgconfig files.

Fixes #14775.

@JackBoosY JackBoosY added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Nov 26, 2020
@JackBoosY
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@NancyLi1013 NancyLi1013 added the info:reviewed Pull Request changes follow basic guidelines label Nov 27, 2020
@Neumann-A
Copy link
Contributor

the issue also indicates that a vcpkg_fixup_pkgconfig() call is missing from the portfile.

@JackBoosY
Copy link
Contributor Author

@Neumann-A Yes, I've already added it.

@strega-nil strega-nil merged commit 8f7de27 into microsoft:master Nov 30, 2020
@strega-nil
Copy link
Contributor

Thanks @JackBoosY

@JackBoosY JackBoosY deleted the dev/jack/14775 branch December 1, 2020 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NancyLi1013 NancyLi1013 NancyLi1013 approved these changes

Assignees

@NancyLi1013 NancyLi1013

Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[devil] pkg-config files specify non-existent IL.lib
4 participants
@JackBoosY @Neumann-A @strega-nil @NancyLi1013