[ace] copy generated headers files for tao #14768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JackBoosY
suggested changes
Nov 26, 2020
JackBoosY
added
category:port-feature
|
Sorry forgot about the Port-Version, I updated the control file. |
|
Will check the output manually later. |
|
LGTM. |
JackBoosY
approved these changes
Nov 30, 2020
|
Thanks @victorburckel ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
For tao feature, some header files are generated by the tao_idl compiler. Also install those generated headers in the package. As vcpkg_install_msbuild generate a temporary build folder, skip clean at first to keep generated files, copy the files from the copy source folder instead of the source folder at the end of the process, and finally execture the clean up proces
What does your PR fix?
Add missing headers for TAO
Which triplets are supported/not supported? Have you updated the CI baseline?
This fixes the windows x86 and x64 packages
Does your PR follow the maintainer guide?
yes