[libtorrent] Update to 1.2.11 #14755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glassez
approved these changes
Nov 24, 2020
zywo
approved these changes
Nov 24, 2020
NancyLi1013
suggested changes
Nov 25, 2020
NancyLi1013
added
category:port-update
This was referenced Nov 25, 2020
NancyLi1013
added
the
requires:all-feature-testing
- Remove python bindings patch, upstream now has the relevant fixes - Remove patch related to finding boost libs, not needed anymore - The [python] and [test] features no longer depend on [deprfun]
FranciscoPombal
force-pushed
the
update_libtorrent
branch
from
b967cc8 to
814ca56
Compare
|
@NancyLi1013 Sorry for the delay. All comments addressed. |
|
Thanks for your update. Have you tested these features? If not, I will test them on my local. |
Yes, on both Windows and Linux (Ubuntu 18.04). But feel free to reproduce on your local setup. |
NancyLi1013
approved these changes
Dec 2, 2020
NancyLi1013
removed
requires:all-feature-testing
glassez
approved these changes
Dec 2, 2020
|
LGTM now, thanks for your PR @FranciscoPombal . |
|
Excuse my curiosity, is there something else that prevents this PR from being merged? |
|
Thanks for your help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously: #13341 and #13375
The
[python]feature is still a no-go on Windows. All else works fine on my end.Updating to 2.0 will take a while, there is ongoing discussion about that in #14293. In the meantime, this one can be merged to provide the latest fixes.