Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cudnn] Try to find CUDNN locally before downloading #14686

Merged
merged 2 commits into from
Nov 23, 2020
Merged

[cudnn] Try to find CUDNN locally before downloading #14686

merged 2 commits into from
Nov 23, 2020

Conversation

jacobkahn
Copy link
Contributor

Don't download cuDNN unless it's not found on the local system.

This allows using newer versions of cuDNN (esp those compiled with newer versions of CUDA) as dependencies in packages.

  • Which triplets are supported/not supported? Have you updated the CI baseline?
    Same as before. Tested x64-linux.

  • Does your PR follow the maintainer guide?

Yes

@PhoebeHui PhoebeHui added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Nov 23, 2020
PhoebeHui
PhoebeHui requested changes Nov 23, 2020
View reviewed changes
Copy link
Contributor

@PhoebeHui PhoebeHui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

Could you update the Port-Version to 3 in CONTROL file?

@jacobkahn
Copy link
Contributor Author

@PhoebeHui done!

@jacobkahn jacobkahn requested a review from PhoebeHui November 23, 2020 05:18
@PhoebeHui PhoebeHui added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Nov 23, 2020
PhoebeHui
PhoebeHui approved these changes Nov 23, 2020
View reviewed changes
Copy link
Contributor

@PhoebeHui PhoebeHui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @strega-nil, could you help further review?

@PhoebeHui PhoebeHui requested a review from strega-nil November 23, 2020 05:52
@strega-nil strega-nil merged commit 820ad09 into microsoft:master Nov 23, 2020
@strega-nil
Copy link
Contributor

Awesome, thanks @jacobkahn :)

@jacobkahn jacobkahn deleted the cudnn_check branch November 23, 2020 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhoebeHui PhoebeHui PhoebeHui approved these changes

@strega-nil strega-nil Awaiting requested review from strega-nil

Assignees

@PhoebeHui PhoebeHui

Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jacobkahn @strega-nil @PhoebeHui