Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[clamav] Add new port #14658

Merged
merged 12 commits into from
Mar 29, 2021
Merged

[clamav] Add new port #14658

merged 12 commits into from
Mar 29, 2021

Conversation

zaddach
Copy link
Contributor

@zaddach zaddach commented Nov 19, 2020

Adds port for ClamAV

  • Tested on x64_windows

@ghost
Copy link

ghost commented Nov 19, 2020 •
edited by ghost
Loading

CLA assistant check
All CLA requirements met.

@NancyLi1013 NancyLi1013 self-assigned this Nov 20, 2020
@NancyLi1013 NancyLi1013 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Nov 20, 2020
NancyLi1013
NancyLi1013 suggested changes Nov 20, 2020
View reviewed changes
@zaddach
Copy link
Contributor Author

zaddach commented Nov 20, 2020

Thanks for the review! I've pushed an update.

val-ms
val-ms reviewed Nov 20, 2020
View reviewed changes
@zaddach
Copy link
Contributor Author

zaddach commented Nov 27, 2020

I've fixed the windows static build as well as the Linux/OsX build.

@zaddach zaddach requested a review from NancyLi1013 November 27, 2020 18:26
JackBoosY
JackBoosY suggested changes Dec 1, 2020
View reviewed changes
JackBoosY
JackBoosY suggested changes Dec 1, 2020
View reviewed changes
NancyLi1013
NancyLi1013 suggested changes Dec 2, 2020
View reviewed changes
@JackBoosY JackBoosY requested a review from NancyLi1013 December 4, 2020 02:15
@NancyLi1013 NancyLi1013 added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Dec 4, 2020
BillyONeal
BillyONeal reviewed Dec 4, 2020
View reviewed changes
@JackBoosY JackBoosY added requires:author-response and removed info:reviewed Pull Request changes follow basic guidelines labels Dec 7, 2020
@NancyLi1013
Copy link
Contributor

@zaddach

Could you please address the review suggestion? Thanks.

@zaddach
Copy link
Contributor Author

zaddach commented Feb 19, 2021

Hey, I can't reproduce the build failure in the x86_windows pipeline. Is this just a pipeline hiccup, or a real problem?

@JackBoosY
Copy link
Contributor

@zaddach Note for changes, we should use ./vcpkg x-add-version --all to generate port version info and commit the changes.

@zaddach
Copy link
Contributor Author

zaddach commented Feb 20, 2021

Thank you for your help!

@NancyLi1013 NancyLi1013 added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Feb 20, 2021
@vicroms vicroms merged commit 7adc87e into microsoft:master Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillyONeal BillyONeal BillyONeal left review comments

@val-ms val-ms val-ms left review comments

@NancyLi1013 NancyLi1013 NancyLi1013 approved these changes

@JackBoosY JackBoosY JackBoosY approved these changes

Assignees

@NancyLi1013 NancyLi1013

Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@zaddach @NancyLi1013 @JackBoosY @BillyONeal @val-ms @vicroms