Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[python3] fix compatibility with macOS 11 big sur #14653

Closed
wants to merge 1 commit into from
Closed

[python3] fix compatibility with macOS 11 big sur #14653

wants to merge 1 commit into from

Conversation

cenit
Copy link
Contributor

@cenit cenit commented Nov 19, 2020

Describe the pull request
fix compatibility with macOS Big Sur

@cenit
Copy link
Contributor Author

cenit commented Nov 19, 2020

Almost sure that qt5-location is broken not because of this PR

@Hoikas
Copy link
Contributor

Hoikas commented Nov 19, 2020

Big Sur is fixed in 3.9.0 according to the Python release notes. See #14510.

@JackBoosY
Copy link
Contributor

@cenit what do you think? should we wait for #14510 merge?

@JackBoosY JackBoosY added the category:port-bug The issue is with a library, which is something the port should already support label Nov 20, 2020
@cenit
Copy link
Contributor Author

cenit commented Nov 20, 2020

This PR should be much lighter and unblock macOS 11, while waiting for the very nice update to python 3.9. The problem was especially in the new number. Nothing very serious beside that is applied in this patch, which is already in use in the homebrew port.

@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Nov 20, 2020
@Hoikas
Copy link
Contributor

Hoikas commented Nov 20, 2020 •
edited
Loading

I disagree with this approach. The patch included here was introduced into python 3.8.4 upstream but does not in fact completely support big sur, as mentioned in the python release notes. It merely fixes the error in the configure script. At bare minimum, the port should be bumped to 3.8.4 (the current release is 3.8.6). The correct fix is to adopt #14510, which is ready (except for false negatives in the baseline).

@Hoikas
Copy link
Contributor

Hoikas commented Nov 20, 2020

See also: Python 3.8 Changelog

@strega-nil
Copy link
Contributor

Closed in favor of #14510

@strega-nil strega-nil closed this Nov 20, 2020
@cenit cenit deleted the dev/cenit/py3_bigsur branch February 8, 2021 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JackBoosY JackBoosY JackBoosY approved these changes

Assignees

@JackBoosY JackBoosY

Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cenit @Hoikas @JackBoosY @strega-nil