Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[seal] Update to version 3.6.0. Changed default features. #14576

Merged
merged 7 commits into from
Nov 18, 2020
Merged

[seal] Update to version 3.6.0. Changed default features. #14576

merged 7 commits into from
Nov 18, 2020

Conversation

WeiDaiWD
Copy link
Contributor

Describe the pull request

Updated ports/seal to version 3.6.0. A new feature zstd is added. Default features include all optional features, because these features are all recommended. Both dynamic linking and static linking work except for Windows where only static linking is supported. If on Windows dynamic linking is detected, a CMake fatal error will be thrown with an explanation. Previous patch file is removed since SEAL 3.6.0 includes necessary changes to support vcpkg.

  • What does your PR fix? Fixes #

Updated ports/seal to version 3.6.0. Changed default features to enable all.

  • Which triplets are supported/not supported? Have you updated the CI baseline?

Supported: x64-linux, x64-windows-static, x86-windows-static.

Not supported: x64-windows, x86-windows, arm64-windows.

Not tested but should be supported: x64-osx and other linux/osx community triplets.

I have not updated the CI baseline.

Yes.

…ted linux and *-windows-static. macOS is not tested but should work.
@NancyLi1013 NancyLi1013 self-assigned this Nov 16, 2020
@NancyLi1013 NancyLi1013 added the category:port-update The issue is with a library, which is requesting update new revision label Nov 16, 2020
@NancyLi1013 NancyLi1013 changed the title Updated ports/seal to version 3.6.0. Changed default features. [seal] Update to version 3.6.0. Changed default features. Nov 16, 2020
@NancyLi1013 NancyLi1013 added category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist requires:author-response labels Nov 16, 2020
Wei Dai added 2 commits November 16, 2020 21:47
@WeiDaiWD
Copy link
Contributor Author

Windows triplets failed randomly. Why is that?

@NancyLi1013
Copy link
Contributor

CMake Error at CMakeLists.txt:578 (configure_file):
  configure_file Problem configuring file


CMake Error at CMakeLists.txt:609 (configure_file):
  configure_file Problem configuring file

You can try to add DISABLE_PARALLEL_CONFIGURE to vcpkg_configure_cmake().

@WeiDaiWD
Copy link
Contributor Author

CMake Error at CMakeLists.txt:578 (configure_file):
  configure_file Problem configuring file


CMake Error at CMakeLists.txt:609 (configure_file):
  configure_file Problem configuring file

You can try to add DISABLE_PARALLEL_CONFIGURE to vcpkg_configure_cmake().

This is resolved. Thanks!

@WeiDaiWD
Copy link
Contributor Author

WeiDaiWD commented Nov 17, 2020

Is there a way to point to a repository's branch name rather than a commit hash? So that we can always get an up-to-date version.

@NancyLi1013
Copy link
Contributor

Is there a way to point to a repository's branch name rather than a commit hash? So that we can always get an up-to-date version.

Currently, there is no way to do this. Actually, we don't recommend to do like this. We prefer to use the commit for a stable version rather than a branch or a tag. Since the commit is the only one, which is more stable to be maintained.

@WeiDaiWD
Copy link
Contributor Author

Is there a way to point to a repository's branch name rather than a commit hash? So that we can always get an up-to-date version.

Currently, there is no way to do this. Actually, we don't recommend to do like this. We prefer to use the commit for a stable version rather than a branch or a tag. Since the commit is the only one, which is more stable to be maintained.

Got it! Thanks! Sorry for the confusion, my latest changes to commit hash do not affect the library built. Those updates do not affect vcpkg. Is there anything else I should do for this PR?

@NancyLi1013
Copy link
Contributor

There is nothing else needs to be done for this PR now except for the last review suggestion.

Co-authored-by: NancyLi1013 <[email protected]>
@strega-nil strega-nil merged commit f6612d5 into microsoft:master Nov 18, 2020
@strega-nil
Copy link
Contributor

Thanks @WeiDaiWD!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist category:port-update The issue is with a library, which is requesting update new revision
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants