-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[seal] Update to version 3.6.0. Changed default features. #14576
Conversation
…ted linux and *-windows-static. macOS is not tested but should work.
…ted SEAL's commit hash to keep up-to-date with SEAL's new fixes.
Windows triplets failed randomly. Why is that? |
You can try to add |
This is resolved. Thanks! |
Is there a way to point to a repository's branch name rather than a commit hash? So that we can always get an up-to-date version. |
Currently, there is no way to do this. Actually, we don't recommend to do like this. We prefer to use the commit for a stable version rather than a branch or a tag. Since the commit is the only one, which is more stable to be maintained. |
Got it! Thanks! Sorry for the confusion, my latest changes to commit hash do not affect the library built. Those updates do not affect vcpkg. Is there anything else I should do for this PR? |
There is nothing else needs to be done for this PR now except for the last review suggestion. |
Co-authored-by: NancyLi1013 <[email protected]>
Thanks @WeiDaiWD! |
Describe the pull request
Updated ports/seal to version 3.6.0. A new feature zstd is added. Default features include all optional features, because these features are all recommended. Both dynamic linking and static linking work except for Windows where only static linking is supported. If on Windows dynamic linking is detected, a CMake fatal error will be thrown with an explanation. Previous patch file is removed since SEAL 3.6.0 includes necessary changes to support vcpkg.
Updated ports/seal to version 3.6.0. Changed default features to enable all.
Supported: x64-linux, x64-windows-static, x86-windows-static.
Not supported: x64-windows, x86-windows, arm64-windows.
Not tested but should be supported: x64-osx and other linux/osx community triplets.
I have not updated the CI baseline.
Yes.