[libflac] require NASM for libflac[asm] #14465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NancyLi1013
reviewed
Nov 9, 2020
NancyLi1013
added
category:port-bug
NancyLi1013
changed the title
|
|
NancyLi1013
approved these changes
Nov 9, 2020
NancyLi1013
added
info:reviewed
|
LGTM now, thanks for your PR @cbergemann . |
strega-nil
reviewed
Nov 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
This pull request will make sure NASM is used when libflac is compiled with assembler [asm] support.
Without this patch, if NASM is not installed, the compilation will complete, silently ignoring the request for assembler support.
This does only affect x86, since the asm option is x86-only.
As far as I can see yes, let me know if there are changes needed.