Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[protopuf] Add a new port protopuf #14446

Merged
merged 4 commits into from
Nov 9, 2020
Merged

[protopuf] Add a new port protopuf #14446

merged 4 commits into from
Nov 9, 2020

Conversation

PragmaTwice
Copy link
Contributor

@PragmaTwice PragmaTwice commented Nov 7, 2020 •
edited
Loading

This PR is meant to add a new port protopuf.

  • Which triplets are supported/not supported? Have you updated the CI baseline?
    It builds on Windows (Visual Studio 2019 Version 16.6), Mac OS and Linux (GCC 10.2), header only. See actions.

  • Does your PR follow the maintainer guide?
    Yes.

@ghost
Copy link

ghost commented Nov 7, 2020 •
edited by ghost
Loading

CLA assistant check
All CLA requirements met.

@JackBoosY JackBoosY added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Nov 8, 2020
@PragmaTwice
Copy link
Contributor Author

PragmaTwice commented Nov 8, 2020 •
edited
Loading

NOTE: I retagged v1.0.0 of protopuf just now to fix a bug related to MSVC debug mode, hence I changed the sha512 code in
e3cd6f2.
From then on, I won’t change it again before merged.

PhoebeHui
PhoebeHui requested changes Nov 9, 2020
View reviewed changes
Copy link
Contributor

@PhoebeHui PhoebeHui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@PragmaTwice PragmaTwice requested a review from PhoebeHui November 9, 2020 08:42
PhoebeHui
PhoebeHui approved these changes Nov 9, 2020
View reviewed changes
Copy link
Contributor

@PhoebeHui PhoebeHui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your updates!

@PhoebeHui PhoebeHui added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Nov 9, 2020
@strega-nil strega-nil merged commit 10c3837 into microsoft:master Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhoebeHui PhoebeHui PhoebeHui approved these changes

Assignees

@PhoebeHui PhoebeHui

Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@PragmaTwice @PhoebeHui @strega-nil @JackBoosY