Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[xeus] remove openssl static build patch as it is no longer needed #14387

Merged

Conversation

mcmtroffaes
Copy link
Contributor

  • What does your PR fix? Since [OpenSSL] refactor openssl ports. #14308 has been merged, the vcpkg wrapper for FindOpenSSL now adds crypt32 automatically to the interface link libraries, so the static build patch is no longer required to build xeus.

  • Which triplets are supported/not supported? Have you updated the CI baseline? No changes.

  • Does your PR follow the maintainer guide? Yes, to the best of my knowledge.

@LilyWangL LilyWangL self-assigned this Nov 5, 2020
@LilyWangL LilyWangL added the category:port-bug The issue is with a library, which is something the port should already support label Nov 5, 2020
@LilyWangL LilyWangL added the info:reviewed Pull Request changes follow basic guidelines label Nov 5, 2020
@BillyONeal BillyONeal merged commit 34283f5 into microsoft:master Nov 5, 2020
@BillyONeal
Copy link
Member

Thanks for your help!

@mcmtroffaes mcmtroffaes deleted the feature/xeus-openssl-cleanup branch November 5, 2020 22:57
@mcmtroffaes
Copy link
Contributor Author

You're welcome, and thanks for the quick review and merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants