-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[libigl] Fix dynamic build and enable header-only mode #14376
[libigl] Fix dynamic build and enable header-only mode #14376
Conversation
b732c8b
to
4c40207
Compare
Alright so, despite compiling successfully, the baseline x64-windows-static is not actually usable. It leads to However my question is, should Otherwise, I am out of idea to make the static build actually be usable. Since it does not alter the original behavior (on x64-windows) the PR should be ok, but could be simplified if dynamic only is decided (I most probably added too many Let me know your opinion on the subject |
The CI x86_windows instance is hogging. For convenience, I made the gist with the test files here (requires building igl from head for fixes on writeDAE): https://gist.github.com/FabienPean/9c1a6c5eea6b304d0e1241024e0387b1 |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Thanks @FabienPean :) |
[libigl] Fix dynamic build and enable header-only mode (microsoft#14376)
This is an attempt at getting rid of libigl huge static .lib file and getting the header-library mode. I could make it work on my machine (Windows VS2019 Clang 10) with the current set of modifications. Not necessarily optimal nor "clean", but hopefully a good start to resolve the issue.
Let me know if anything is missing or feel free to take over from here.
What does your PR fix? Fixes [libigl] Enable header-only mode #14371
Which triplets are supported/not supported? Have you updated the CI baseline?
Dynamic library version works on windows but not the static, and other platform untested. I don't know what is the CI baseline.
Does your PR follow the maintainer guide?
I think so.