Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[libsamplerate, sdl2-gfx] Fix build error with Visual Studio 2019 version 16.8 #14348

Merged
merged 1 commit into from
Nov 4, 2020
Merged

[libsamplerate, sdl2-gfx] Fix build error with Visual Studio 2019 version 16.8 #14348

merged 1 commit into from
Nov 4, 2020

Conversation

LilyWangL
Copy link
Contributor

Describe the pull request

  • What does your PR fix?
    Visual Studio 2019 version 16.8 do not have lrint and lrintf. So libsamplerate and sdl2-gfx build failed on Visual Studio 2019 version 16.8 with the following error:
    libsamplerate:
D:\buildtrees\libsamplerate\src\9c5825142a-a07e6bb3f6.clean\src\float_cast.h(130): error C2169: 'lrint': intrinsic function, cannot be defined
D:\buildtrees\libsamplerate\src\9c5825142a-a07e6bb3f6.clean\src\float_cast.h(136): error C2169: 'lrintf': intrinsic function, cannot be defined

sdl2-gfx:

D:\buildtrees\sdl2-gfx\src\1.0.4-86ce4cf464.clean\SDL2_gfxPrimitives.c(1766): error C2169: 'lrint': intrinsic function, cannot be defined

Adding patch to fix this error. The upstream of libsamplerate remove float_cast.h in latest version.

@LilyWangL LilyWangL added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Nov 2, 2020
@LilyWangL LilyWangL requested a review from BillyONeal November 2, 2020 07:44
@LilyWangL LilyWangL marked this pull request as ready for review November 2, 2020 08:10
@NancyLi1013 NancyLi1013 added the info:reviewed Pull Request changes follow basic guidelines label Nov 3, 2020
@BillyONeal BillyONeal merged commit 0b26c1f into microsoft:master Nov 4, 2020
@BillyONeal
Copy link
Member

Thanks for beating me to this!

xTVaser added a commit to xTVaser/pcsx2-rr that referenced this pull request Mar 5, 2021
@xTVaser
vs/deps: Workaround patch for libsamplerate on VS 16.9
d24e021 
Taken from microsoft/vcpkg#14348

I believe this is also fixed in the latest version `0.2.1` so likely good followup work (it removes float_case entirely) but I wasn't able to get VS to build it, atleast this gets things back to a build-able state in the interim.
@xTVaser xTVaser mentioned this pull request Mar 5, 2021
Closed
xTVaser added a commit to xTVaser/pcsx2-rr that referenced this pull request Mar 5, 2021
@xTVaser
vs/deps: Workaround patch for libsamplerate on VS 16.9
9ce4a6f 
Taken from microsoft/vcpkg#14348

I believe this is also fixed in the latest version `0.2.1` so likely good followup work (it removes float_case entirely) but I wasn't able to get VS to build it, atleast this gets things back to a build-able state in the interim.
@waych waych mentioned this pull request Mar 30, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NancyLi1013 NancyLi1013 NancyLi1013 approved these changes

@BillyONeal BillyONeal Awaiting requested review from BillyONeal

Assignees

@NancyLi1013 NancyLi1013

Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LilyWangL @BillyONeal @NancyLi1013