[libmysql/libmariadb] Export unofficial cmake targets #14290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JackBoosY
added
category:port-feature
JackBoosY
changed the title
JackBoosY
changed the title
PhoebeHui
approved these changes
Oct 30, 2020
BillyONeal
reviewed
Oct 30, 2020
JackBoosY
commented
Oct 31, 2020
|
I'm not ignoring this one but I want to go over it with some other team members who understand the implications better than I do; should land Monday at the latest. Thanks for your contribution! |
JackBoosY
added
the
category:tool-update
|
Done, already tested usage with poco. |
|
Depends on #14396. |
JackBoosY
added
depends:different-pr
added 2 commits
November 5, 2020 18:25
JackBoosY
removed
the
depends:different-pr
3 tasks
PhoebeHui
approved these changes
Nov 9, 2020
strega-nil
reviewed
Nov 9, 2020
|
Merging after a run-through of CI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to use libmysql and libmariadb easily, export the unofficial targets.
For libmysql, since the library and the target generated by its dynamic build and static build is inconsistent, a wrapper is added to unify the output interface.
When the executable in the bin is cleaned up, the executable related pdb also need to be cleaned up.
This PR prepares for poco update.