Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[libjuice] Update libjuice for libdatachannel port. #14213

Merged
merged 4 commits into from
Nov 18, 2020
Merged

[libjuice] Update libjuice for libdatachannel port. #14213

merged 4 commits into from
Nov 18, 2020

Conversation

Nemirtingas
Copy link
Contributor

A version update for libjuice.

  • What does your PR fix?
    Need to update libjuice to merge libdatachannel port.

@Nemirtingas Nemirtingas mentioned this pull request Oct 25, 2020
Merged
@NancyLi1013 NancyLi1013 added the category:port-update The issue is with a library, which is requesting update new revision label Oct 26, 2020
NancyLi1013
NancyLi1013 suggested changes Oct 26, 2020
View reviewed changes
@NancyLi1013
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@NancyLi1013
Copy link
Contributor

The failure on x86-windows caused by gmp will be fixed via PR #14003.

@NancyLi1013 NancyLi1013 added the info:reviewed Pull Request changes follow basic guidelines label Oct 29, 2020
@NancyLi1013
Copy link
Contributor

LGTM now, thanks for your PR @Nemirtingas.

@BillyONeal
Copy link
Member

@Nemirtingas Upstream seems to release fairly frequently here and this updates the port from an orderable version to an unorderable version. Have you asked upstream (or @paullouisageneau or @hanseuljun who seem to contribute there) to drop a release?

Thanks!

@paullouisageneau
Copy link

I'm planning to do a 0.10.0 release of libdatachannel after integrating one last big PR, probably in one week or so. I'll release libjuice at the same time.

@BillyONeal BillyONeal added depends:upstream-changes Waiting on a change to the upstream project and removed info:reviewed Pull Request changes follow basic guidelines labels Nov 2, 2020
@BillyONeal
Copy link
Member

@paullouisageneau Thanks! Can you let us know when that happens? We'll update this to your released copy.

@paullouisageneau
Copy link

paullouisageneau commented Nov 15, 2020 •
edited
Loading

@BillyONeal @Nemirtingas Hello, libjuice v0.6.0 and libdatachannel v0.10.1 have been released, thanks for you patience!

@Nemirtingas
Copy link
Contributor Author

Hi, I'll work on the vcpkg port then, ty.

@Nemirtingas
Copy link
Contributor Author

Libjuice is updated to v0.6.0.

@NancyLi1013
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

NancyLi1013
NancyLi1013 suggested changes Nov 17, 2020
View reviewed changes
@NancyLi1013 NancyLi1013 removed the depends:upstream-changes Waiting on a change to the upstream project label Nov 17, 2020
@strega-nil
Copy link
Contributor

Thanks @Nemirtingas !

@strega-nil strega-nil merged commit e93bc55 into microsoft:master Nov 18, 2020
@Nemirtingas Nemirtingas deleted the libjuice_update branch November 22, 2020 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NancyLi1013 NancyLi1013 NancyLi1013 requested changes

Assignees

@NancyLi1013 NancyLi1013

Labels
category:port-update The issue is with a library, which is requesting update new revision
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Nemirtingas @NancyLi1013 @BillyONeal @paullouisageneau @strega-nil @GameDumper