-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[asio] update to version 1.18.0 (#14095) #14167
Conversation
Hi @NancyLi1013 So I have tried to update restbed to the newest version prior to applying the patch you mentioned at #14095 . Unfortunately I getting now the ninja error
|
Okay, the removal of |
when adding 64cfeef it results in the config error. @NancyLi1013 do you have any tips on how to solve this? I don't have any experience with that one. |
Since there are more that one targets generated at the same time. You can add the options
|
@NancyLi1013 now it will build with PREFER_NINJA |
Could you please resolve the conflicts? |
@NancyLi1013 resolved conflicts |
LGTM now. Have you tested the feature |
Co-authored-by: NancyLi1013 <[email protected]>
I've only build with the openssl feature but didn't compile a test program. I can do that in the evening today. |
@NancyLi1013 I've build restbed[*] with tests. All tests are successfully. |
Awesome! Thanks for your test and feedback. |
Thanks for your contribution! |
This PR is related to #14095
What does your PR fix?
Upates asio to version 1.18.0
Which triplets are supported/not supported? Have you updated the CI baseline?
Does your PR follow the maintainer guide?
yes