-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix forward declarations & replace fwd header files #13972
Fix forward declarations & replace fwd header files #13972
Conversation
781efa2
to
0de673d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just the one thing, otherwise this is so great 😄
@@ -1,16 +1,12 @@ | |||
#pragma once | |||
|
|||
#include <vcpkg/fwd/dependencies.h> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
namespace vckpg::Parse | ||
{ | ||
struct ParseControlErrorInfo; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this not in vcpkg/fwd/paragraphparser.h
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Escaped my notice, I will add a forward declaration file for this :)
0de673d
to
b31623f
Compare
b31623f
to
294a0d4
Compare
(Approval obviously conditioned on a successful build :) ) |
/azp run |
Commenter does not have sufficient privileges for PR 13972 in repo microsoft/vcpkg |
@cngzhnp It got your changes with out azp run : https://dev.azure.com/vcpkg/public/_build/results?buildId=43989&view=results |
294a0d4
to
a609048
Compare
@BillyONeal thanks, maybe not a good place to mention or ask but if the azure-pipelines bot can do format with commands here, it would be easier for us. I always forget to run the format tool before committing the changes :) |
Yeah, it's something we've wanted to do; unfortunately we're stuck between a rock and a hard place here. Azure Pipelines can't write any changes back to GitHub (like the formatting changes we want), and GitHub Actions can't control Azure to create and destroy the test machines (we need bigger than the dual core boxes Actions come with). |
Thanks for the reply @BillyONeal. Now, it is ready to merge I guess. (condition is checked) :) |
a609048
to
4722aa4
Compare
4722aa4
to
a195971
Compare
Thanks for your contribution! |
I had done before in #13623 and these are new fixes for other files as well. I try to use forward declaration files as much as possible. Please give feedback about if new files need to be created.