Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vcpkg_find_acquire_program] Fix SWIG on non-Windows platforms. #13953

Merged
merged 2 commits into from
Oct 23, 2020

Conversation

Hoikas
Copy link
Contributor

@Hoikas Hoikas commented Oct 9, 2020

  • What does your PR fix?
    Previously, the sourceforge downloader was attempting to download a mixture of the Windows URL with an incorrect extension, causing a cascade of HTTPS download failure messages. This was observed when testing [python3] Improve support for embedding and add tools #13556 by building itk[python]:linux-x64 on Ubuntu 20.04.

  • Which triplets are supported/not supported? Have you updated the CI baseline?
    No change.

  • Does your PR follow the maintainer guide?
    Yes

@JackBoosY JackBoosY added the category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly label Oct 10, 2020
@JackBoosY
Copy link
Contributor

Should be good.

Previously, the sourceforge downloader was attempting to download a
mixture of the Windows URL with an incorrect extension, causing a
cascade of HTTPS download failure messages.
@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Oct 23, 2020
@BillyONeal BillyONeal merged commit 50a596c into microsoft:master Oct 23, 2020
@BillyONeal
Copy link
Member

Thanks for your contribution!

@Hoikas Hoikas deleted the swig branch September 10, 2022 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants