Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vcpkg_from_git] Add SHA512 argument, deprecate usage without argument. #13941

Closed
wants to merge 18 commits into from

Conversation

ras0219
Copy link
Contributor

@ras0219 ras0219 commented Oct 9, 2020

This PR adds a SHA512 argument to vcpkg_from_git(), allowing vcpkg to verify the integrity of the intermediate archives. As part of this change, calling vcpkg_from_git() without this argument is deprecated (with a warning) and all ports using vcpkg_from_git() have been updated to pass an appropriate SHA512.

As a drive by fix, this PR also fixes portaudio's ninja 1.9.0 issue by only building one of static/shared.

@ras0219 ras0219 force-pushed the dev/roschuma/vcpkg_from_git branch from 23a1d40 to f9bc44d Compare October 9, 2020 06:29
@JackBoosY JackBoosY self-assigned this Oct 9, 2020
@JackBoosY JackBoosY added category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed info:internal This PR or Issue was filed by the vcpkg team. labels Oct 9, 2020
@strega-nil
Copy link
Contributor

@ras0219 is there anything else to be done here?

@ras0219
Copy link
Contributor Author

ras0219 commented Nov 25, 2020

No functional changes; just a matter of getting a clean build

@strega-nil
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ras0219 ras0219 marked this pull request as draft December 8, 2020 18:36
@ras0219
Copy link
Contributor Author

ras0219 commented Dec 8, 2020

There are additional challenges to be faced with making git.exe produce stable archives across all OSes. Marking this as draft for now until those problems are solved.

  • git.exe uses internal code to produce .tar files, and it changed in 2.26 for repos with paths longer than 100 characters
    • We can make sure we're using a precise git version on Windows, but we can't easily update the git version on other platforms.
  • The .gz format has an OS field that can differ between Windows and non-Windows (note: msys gzip does produce "unix" tagged archives).

@JackBoosY
Copy link
Contributor

This PR has been inactive for a long time, please reopen it if there is any progress.

@JackBoosY JackBoosY closed this Sep 10, 2021
@autoantwort
Copy link
Contributor

Would be cool to get this in some kind so that asset caching would capture git repos too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed info:internal This PR or Issue was filed by the vcpkg team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants