[vcpkg macos ci] Switch to using our own base boxes, to fix bringing up mac machines #13619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strega-nil
added
the
category:infrastructure
mecab needed to use an actual ref that wasn't master, and jxrlib needed a patch for xcode 12 CLTs. Additionally, this fixes the mecab version to be a date, the date of the last commit, since `1.0` is not the correct version (mecab doesn't have released versions)
BillyONeal
approved these changes
Sep 21, 2020
This mostly means fixing errors on implicit-function-declaration, and removing some Werrors * alac-decoder * apr * argtable2 * arrow * hyperscan * mcpp * minizip * mosquitto * stormlib
ras0219-msft
approved these changes
Sep 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we use
ramsey/macos-catalinaas our base image, which doesn't have Xcode and such installed. Recently, Apple brokexcode-select --install, which is how we were installing xcode into the VMs. Thus, we need to figure out another way to get xcode onto these machines, and so I've done that by creating a new base box (which is non-public, so there's no concern about licensing, sorry y'all), which has the Xcode Command Line Tools preinstalled.This also adds instructions for creating a new base box, and changes to the scripts to allow us to use the new base boxes.
Additionally, it removes the
brew installfrom the CI pipeline, since we had trouble with it; all packages that are necessary should be preinstalled by theVagrantfile.Additionally, before this is merged, I'd like to turn the instructions for creating a new base box into a script, and additionally add a script for getting the base box onto the machine.
Additionally, as a drive-by, renames VagrantFile -> Vagrantfile, which is the actual capitalization used by vagrant (it worked before by virtue of case-insensitivity).