-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[qt5-location] Rename vendored libs to avoid conflicts #13451
[qt5-location] Rename vendored libs to avoid conflicts #13451
Conversation
Use upstream patch instead: https://codereview.qt-project.org/c/qt/qtlocation/+/312221 ? |
Is this why we've been getting those intermittent failures of qt stuff? |
@BillyONeal Part of these regressions. |
…9/vcpkg into dev/roschuma/qt5-location
…roschuma/qt5-location
@BillyONeal This should only affect qt5-location; this doesn't explain any other random Qt failures |
Most random qt build failures are due to parallel builds. |
@ras0219-msft I think this change broke my code (specifically this commit: 208666f). It seems that Assimp now links against the entire Irrlicht engine, rather than just IrrXML, but since Irrlicht defines WndProc, I get a linker error:
It looks like Assimp doesn't require Irrlicht as a dependency, only IrrXML: https://github.com/assimp/assimp/blob/95d0443a5d8417051844ddfff9ad9a013b66abd9/cmake-modules/FindIrrXML.cmake |
cc @ras0219 |
Hi, I managed to work around the issue by putting my WndProc in an anonymous namespace, but I'm still not sure it's a good idea to add the whole of Irrlicht as a dependency here if it can be avoided. |
Extracted from #12199