-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[vcpkg] Avoid computing triplet ABIs for editable packages #13446
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this have a test?
Adding a test would require mocking |
I don't mean a unit test, I mean in the e2e tests. |
@ras0219 Works as advertised. Thank you! |
…ing by default, and --editable
/azp run |
No pipelines are associated with this pull request. |
…#13446) * [vcpkg] Avoid computing triplet ABIs for editable packages * [vcpkg] Address PR comments * [vcpkg-end-to-end-tests] Add tests for --no-binarycaching, binarycaching by default, and --editable Co-authored-by: Robert Schumacher <[email protected]>
This PR delays computation of
abi_info.triplet_abi
until after we perform a check for conditions that would disable computation of a package abi. This can save several seconds in the port inner-dev loop.The specific examples of this case are
--editable
and--head
, which will both disable our ability to compute ABIs. Furthermore, if a package without an ABI is installed, all transitive consumers also cannot have their ABIs computed.Before:
After:
+@qis who may be particularly happy about this change :)