[triangle] Add new port

[n4z4m3]

Add the libigl-triangle port as per Issue #12564
Fixes #12564

[cenit]

Can you please use official sources and not unofficial repository?
http://www.netlib.org/voronoi/triangle.zip

[cenit]

Also, you install the header both in the CMakeLists and in the portfile. One should be enough :)

[cenit]

Final note: can you please also provide CMake targets, to link to triangle (prefixed with unofficial is ok if you prefer)

[NancyLi1013]

Can you please use official sources and not unofficial repository?
http://www.netlib.org/voronoi/triangle.zip

It seems the repository is not unofficial repository. I noticed that libigl also used https://github.com/libigl/libigl.
But I'm also not sure about this.

@BillyONeal
Could you please help review this point? Also for the port name, I don't know if libigl-triangle is suitable. Or we might rename it as triangle.

[cenit]

It seems the repository is not unofficial repository

It is. I am also a user of triangle :)
Please look at http://www.cs.cmu.edu/~quake/triangle.html for the official homepage and official download link

[cenit]

It is really the same sources, nothing looks like might warrant even a libigl-triangle duplicate here

[n4z4m3]

Can you please use official sources and not unofficial repository?
http://www.netlib.org/voronoi/triangle.zip

I would like to. The reason I did not is because this is actually not a true mirror of the original sources. It has modifications to the source code that allow it to build as a library and also to support 64-bit architecture. However, I think I should be able to add these changes using patches. I will have to learn how to do the patching. Hopefully the documentation at https://vcpkg.readthedocs.io/en/latest/examples/patching will help.

Also, this should allow me to change the port name to just triangle.

[cenit]

I think I should be able to add these changes using patches. I will have to learn how to do the patching. Hopefully the documentation at https://vcpkg.readthedocs.io/en/latest/examples/patching will help.

yes please.
You will receive support in case of necessity

[n4z4m3]

Final note: can you please also provide CMake targets, to link to triangle (prefixed with unofficial is ok if you prefer)

I would like to, but I am pretty new to both creating vcpkg ports (which is probably pretty obvious by now) and CMake. So I don't really know how to do this. But I will try to figure it out. If you or somebody else can help that would be great. Even just pointing to a good example that I can copy from would be helpful.

[cenit]

I would like to, but I am pretty new to both creating vcpkg ports (which is probably pretty obvious by now) and CMake. So I don't really know how to do this. But I will try to figure it out. If you or somebody else can help that would be great. Even just pointing to a good example that I can copy from would be helpful.

I wrote many CMakeLists.txt for vcpkg. Look for example to ports/vlfeat for an example of a library that installs header files and provides targets for end users

[cenit]

Yeah right direction! 👆🏻

[n4z4m3]

I believe I have implemented all suggested changes.

I really appreciate all the suggestions. You are all awesome.

Note that there is one more change request which I believe is not going to be made. How do I close that? Or is that something that the person who made the request must do?

[cenit]

Would you mind creating the triangle.exe target and move it to tools? That would make this a fully complete port (and in return you would also learn how to deal with executable tools in vcpkg ;) )

[n4z4m3]

Would you mind creating the triangle.exe target and move it to tools? That would make this a fully complete port (and in return you would also learn how to deal with executable tools in vcpkg ;) )

Yes. This has been done now.

[NancyLi1013]

The regressions on x64-linux:

4/5] : && /usr/bin/cc -fPIC -g  -rdynamic CMakeFiles/triangle.dir/triangle.c.o  -o triangle   && :
FAILED: triangle 
: && /usr/bin/cc -fPIC -g  -rdynamic CMakeFiles/triangle.dir/triangle.c.o  -o triangle   && :
CMakeFiles/triangle.dir/triangle.c.o: In function `parsecommandline':
/mnt/vcpkg-ci/buildtrees/triangle/src/triangle-84d2cb038f.clean/triangle.c:3527: undefined reference to `cos'
/mnt/vcpkg-ci/buildtrees/triangle/src/triangle-84d2cb038f.clean/triangle.c:3531: undefined reference to `sqrt'
CMakeFiles/triangle.dir/triangle.c.o: In function `circletop':
/mnt/vcpkg-ci/buildtrees/triangle/src/triangle-84d2cb038f.clean/triangle.c:10529: undefined reference to `sqrt'
CMakeFiles/triangle.dir/triangle.c.o: In function `splitencsegs':
/mnt/vcpkg-ci/buildtrees/triangle/src/triangle-84d2cb038f.clean/triangle.c:13362: undefined reference to `sqrt'
CMakeFiles/triangle.dir/triangle.c.o: In function `quality_statistics':
/mnt/vcpkg-ci/buildtrees/triangle/src/triangle-84d2cb038f.clean/triangle.c:15392: undefined reference to `cos'
/mnt/vcpkg-ci/buildtrees/triangle/src/triangle-84d2cb038f.clean/triangle.c:15501: undefined reference to `sqrt'
/mnt/vcpkg-ci/buildtrees/triangle/src/triangle-84d2cb038f.clean/triangle.c:15502: undefined reference to `sqrt'
/mnt/vcpkg-ci/buildtrees/triangle/src/triangle-84d2cb038f.clean/triangle.c:15503: undefined reference to `sqrt'
/mnt/vcpkg-ci/buildtrees/triangle/src/triangle-84d2cb038f.clean/triangle.c:15504: undefined reference to `sqrt'
/mnt/vcpkg-ci/buildtrees/triangle/src/triangle-84d2cb038f.clean/triangle.c:15510: undefined reference to `sqrt'
/mnt/vcpkg-ci/buildtrees/triangle/src/triangle-84d2cb038f.clean/triangle.c:15510: undefined reference to `acos'
/mnt/vcpkg-ci/buildtrees/triangle/src/triangle-84d2cb038f.clean/triangle.c:15516: undefined reference to `sqrt'
/mnt/vcpkg-ci/buildtrees/triangle/src/triangle-84d2cb038f.clean/triangle.c:15516: undefined reference to `acos'
/mnt/vcpkg-ci/buildtrees/triangle/src/triangle-84d2cb038f.clean/triangle.c:15518: undefined reference to `sqrt'
/mnt/vcpkg-ci/buildtrees/triangle/src/triangle-84d2cb038f.clean/triangle.c:15518: undefined reference to `acos'
collect2: error: ld returned 1 exit status
ninja: build stopped: subcommand failed.

Could you please look into this?

[n4z4m3]

The regressions on x64-linux:

Could you please look into this?

I believe I have fixed this. However, the checks are not re-running. Is that expected?

[cenit]

Try rebasing on master to re-trigger CI checks

In any case, thanks for applying all suggestions. Port looks very fine for me :)

[n4z4m3]

Try rebasing on master to re-trigger CI checks

In any case, thanks for applying all suggestions. Port looks very fine for me :)

Is this rebasing something I need to do? Because I have never had to do a rebase before and I am worried about messing something up.

[NancyLi1013]

I have merged master to re-trigger CI checks. Let's see the new check results.

[ras0219-msft]

Thanks for the PR!

Other than my one comment, LGTM.

[ras0219-msft]

Thanks for the PR!