-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[openmama] Feature use cmake for openmama #13034
[openmama] Feature use cmake for openmama #13034
Conversation
@fquinner, thanks for the PR! Could you update the Port-Version in CONTROL file? |
@PhoebeHui Thanks for looking! Yes I just pushed in a commit to include that change, hopefully all is OK now! |
@fquinner, thanks for your updates! I just noticed the following triplets disabled in CI testing, does them support now? if it supports, could you remove them from the ci.baseline file, if not, could you help add them to 'Supports' in CONTROL file? In scripts/ci.baseline.txt file: |
Thanks @PhoebeHui - pushed in some new changes for this to add Supports to CONTROL file and remove entries from ci baseline for failure exceptions that should now work. |
Could you also remove the following lines? openmama:x64-linux=fail |
Ah yes of course with Supports that won't be required any more - will do. |
@PhoebeHui ok that's updated now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Thanks for your contribution! |
Describe the pull request
What does your PR fix? Updates OpenMAMA port to use cmake rather than scons (its new preferred buildsystem)
Which triplets are supported/not supported? Have you updated the CI baseline? x86/x64-release/debug
Does your PR follow the maintainer guide? Yes