Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vcpkg] Add Forward Declarations (originally by @cngzhnp) #12985

Merged
merged 5 commits into from
Aug 19, 2020
Merged

[vcpkg] Add Forward Declarations (originally by @cngzhnp) #12985

merged 5 commits into from
Aug 19, 2020

Conversation

strega-nil
Copy link
Contributor

Based on @cngzhnp's changes in #12836; I prefer this version of the changes, since there's no copy-pasting of forward declarations.

@strega-nil strega-nil changed the title [vcpkg] Add Forward Declarations [vcpkg] Add Forward Declarations (originally by @cngzhnp) Aug 18, 2020
BillyONeal
BillyONeal approved these changes Aug 18, 2020
View reviewed changes
@JackBoosY JackBoosY added category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed info:internal This PR or Issue was filed by the vcpkg team. labels Aug 19, 2020
@strega-nil
Copy link
Contributor Author

strega-nil commented Aug 19, 2020 •
edited
Loading

@BillyONeal made the changes you wanted :) (and also deleted Util::copy, which I feel like has a similar problem to Util::unused, and which was only used in one place)

@BillyONeal
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@BillyONeal BillyONeal mentioned this pull request Aug 19, 2020
Closed
@BillyONeal
Copy link
Member

@cngzhnp and @strega-nil Thanks for your contribution!

@BillyONeal BillyONeal merged commit 5e164e3 into microsoft:master Aug 19, 2020
@strega-nil strega-nil mentioned this pull request Aug 20, 2020
Merged
remz1337 pushed a commit to remz1337/vcpkg that referenced this pull request Aug 23, 2020
@strega-nil @cngzhnp @remz1337
[vcpkg] Add Forward Declarations (originally by @cngzhnp) (microsoft#…
7cfeef5 
…12985)

Co-authored-by: cngzhnp <[email protected]>
@strega-nil strega-nil deleted the cngzhnp/fix_forward_declarations branch September 10, 2020 21:21
strega-nil added a commit to strega-nil/vcpkg that referenced this pull request May 5, 2021
@strega-nil @cngzhnp
[vcpkg] Add Forward Declarations (originally by @cngzhnp) (microsoft#…
ed78528 
…12985)

Co-authored-by: cngzhnp <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillyONeal BillyONeal BillyONeal approved these changes

@cngzhnp cngzhnp cngzhnp approved these changes

Assignees

@PhoebeHui PhoebeHui

@JackBoosY JackBoosY

Labels
category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed info:internal This PR or Issue was filed by the vcpkg team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@strega-nil @BillyONeal @cngzhnp @PhoebeHui @JackBoosY